Add D41x support - #266
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for D41x Intel RealSense cameras to the existing D4xx kernel driver. The changes include adding device type definitions, resolution configurations, and format specifications specific to the D41x variant.
- Adds D41x device type constant and configuration structures for depth and calibration modes
- Updates the driver probe message to be more generic for all D4xx devices
- Increments module version to reflect the new D41x support
| .width = 256, | ||
| .height = 144, | ||
| .framerates = ds5_framerate_90, | ||
| .n_framerates = ARRAY_SIZE(ds5_framerate_90), |
There was a problem hiding this comment.
Inconsistent framerate array usage. All other entries in d41x_depth_sizes use ds5_framerate_to_90 but this entry uses ds5_framerate_90. This should likely be ds5_framerate_to_90 for consistency, unless there's a specific reason for this 256x144 resolution to only support 90fps.
Suggested change
| .n_framerates = ARRAY_SIZE(ds5_framerate_90), | |
| .framerates = ds5_framerate_to_90, | |
| .n_framerates = ARRAY_SIZE(ds5_framerate_to_90), |
santhosh-12250986
force-pushed
the
D41x_support
branch
from
August 13, 2025 08:24
7a02f24 to
a959cc5
Compare
santhosh-12250986
force-pushed
the
D41x_support
branch
from
August 13, 2025 08:32
a959cc5 to
fd1f665
Compare
Nir-Az
approved these changes
Aug 26, 2025
ymodlin
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Add D41x support * Bump module version * Fix D41x resolutions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.